Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gosdk #378

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Upgrade gosdk #378

merged 1 commit into from
Mar 8, 2023

Conversation

lpoli
Copy link
Contributor

@lpoli lpoli commented Mar 8, 2023

A brief description of the changes in this PR:

Upgrade to latest gosdk.
System tests are failing due to latest changes in gosdk

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@lpoli lpoli requested a review from cnlangzi March 8, 2023 04:41
cnlangzi
cnlangzi approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@cnlangzi cnlangzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpoli lpoli merged commit c17ead3 into staging Mar 8, 2023
@lpoli lpoli deleted the upgrade/gosdk branch March 8, 2023 05:58
@cnlangzi cnlangzi mentioned this pull request Mar 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnlangzi cnlangzi cnlangzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpoli @cnlangzi