Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upload): encrypt thumbnail bytes #386

Merged
merged 20 commits into from
Mar 24, 2023
Merged

fix(upload): encrypt thumbnail bytes #386

merged 20 commits into from
Mar 24, 2023

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Mar 15, 2023 •
edited
Loading

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

dabasov and others added 16 commits September 29, 2022 18:00
@dabasov
updated gosdk version
35214af
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
e181824 
# Conflicts:
#	go.mod
#	go.sum
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
0a8343f
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
8ac4d79
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
caff767
@areebusmani
Remove allocation name
d19fb05
@areebusmani
Remove allocation name
068d86b
@areebusmani
Update go sdk
dd0a4e3
@areebusmani
Merge branch 'staging' into areeb/allocname
1d1f67f
@areebusmani
Merge branch 'staging' into areeb/allocname
8b0d81d
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
d361795
@dabasov
Merge remote-tracking branch 'origin/areeb/allocname' into staging
a53e0ff 
# Conflicts:
#	cmd/newallocation.go
#	go.mod
#	go.sum
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
e16e00c 
# Conflicts:
#	go.mod
#	go.sum
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
9427320 
# Conflicts:
#	go.mod
#	go.sum
@dabasov
Merge remote-tracking branch 'origin/staging' into staging
b05064b
@cnlangzi
fix(upload): encrypt thumbnail bytes
3bbe443
This was referenced Mar 15, 2023
Merged
Merged
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests fix/encrypt_thumbnail
gosdk fix/encrypt_thumbnail
zboxcli fix/encrypt_thumbnail
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

peterlimg
peterlimg approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/encrypt_thumbnail
gosdk fix/encrypt_thumbnail
zboxcli fix/encrypt_thumbnail
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/encrypt_thumbnail
gosdk fix/encrypt_thumbnail
zboxcli fix/encrypt_thumbnail
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi merged commit 01a1cb2 into staging Mar 24, 2023
@cnlangzi cnlangzi deleted the fix/encrypt_thumbnail branch March 24, 2023 00:30
peterlimg added a commit that referenced this pull request Mar 26, 2023
@peterlimg
Merge branch 'staging' into chain-fee
4844535 
* staging:
  fix(path): replaced filepath methods with pathutil for remotepath (#390)
  fix(cost): fixed get-upload-cost and get-download-cost (#387)
  fix(upload): encrypt thumbnail bytes (#386)
  Makin clientid and encryptionkey mandatory in encrypted share (#385)
  Update Readme.md (#391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when trying to download thumbnail for encrypted file
5 participants
@cnlangzi @service-0chain @peterlimg @dabasov @areebusmani