Update yahnis-elsts/plugin-update-checker from 4.9 to 4.13
#937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
changed the title
yahnis-elsts/plugin-update-checker from 4.9 to 4.13
This was referenced Sep 8, 2022
dkotter
requested review from
a team and
cadic
and removed request for
a team
peterwilsoncc
approved these changes
Sep 12, 2022
peterwilsoncc
added a commit
that referenced
this pull request
Sep 26, 2022
Update `yahnis-elsts/plugin-update-checker` from 4.9 to 4.13 # Conflicts: # composer.json # composer.lock
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The Plugin Update Checker library we use is also used on a few other 10up projects. Some of those are running different versions though, leading to conflicts (especially when using composer to manage all dependencies of a project). This PR updates this library to the latest version, which will also be done in other repos that are using this library.
Alternatively we could use something like mozart or PHP-Scoper to add a distinct namespace to this dependency. I'm not opposed to this necessarily but because we're seeing conflicts with other plugins that we fully control, I like the idea of just ensuring all of those projects are using the same version.
How to test the Change
distributor.phpfile, set the version number to something lower, like 1.6.0Check for updateslink; also ensure the plugin is active)View version X.X.X detailslink and ensure you see proper detailsView version X.X.X detailslink and ensure you see proper detailsupdate nowlink and ensure an update works (either from the plugins page or the main updates page). Note though that this will wipe out your version controlleddistributordirectory, so proceed with cautionChangelog Entry
Credits
Props @dkotter
Checklist: