Implementation of Characteristic descriptor discovery #74
Conversation
BLE_GATT_STATUS_SUCCESS. Report error in the Termination callback
Fix terminate discovery (the replacement of the discovery was done after the call to terminate). When searching for a running discovery, dismiss results where the characteristic is equal to the default characteristic value Add Discovery::operator!= Add support of DiscoveredCharacteristic last handle in the characteristic discovery process
Use const references for passing characteristic discovery callbacks Fix a bug in btle_discovery.cpp, the discovered descriptors were captured by value instead of reference.
| @@ -183,6 +183,7 @@ static void btle_handler(ble_evt_t *p_ble_evt) | |||
| break; | |||
| } | |||
| nRF5xGap::getInstance().processDisconnectionEvent(handle, reason); | |||
| // TODO: close pending discoveries | |||
There was a problem hiding this comment.
This is a question. Is it required to close pending discovery manually ? If a discovery is running, does the stack will report the discovery that the discovery has failed ? My question apply for service, characteristic and characteristic descriptors discovery.
There was a problem hiding this comment.
I believe we should invoke the serviceDiscoveryTermination callback before invoking disconnectionCallback. Not sure yet how to report a failure to service discovery.
There was a problem hiding this comment.
I have made the changes. I have added a new function in nRF5xServiceDiscovery : void terminate(Gap::Handle_t connectionHandle). It is an overload of terminate, if the handle passed in parameters match the handle of the current discovery, it terminate the discovery otherwise, the discovery continue to run.
Add accessor for ServiceDiscovery and CharacteristicDescriptorDiscover in GattClient. Remove friend relationship with bleGattcEventHandler
| // Close all pending discoveries for this connection | ||
| nRF5xGattClient& gattClient = nRF5xGattClient::getInstance(); | ||
| gattClient.characteristicDescriptorDiscoverer().terminate(handle, BLE_ERROR_INVALID_STATE); | ||
| gattClient.discovery().terminate(handle); |
There was a problem hiding this comment.
thanks for this improvement. :)
|
I've finished my review for the moment. I'll wait for your updates. |
…o characteristicDescriptorDiscovery
discoveredCharacteristic. Add doc to the discovery process and the rationale behind discoveredCharacteristic member.
Simplify the process
…very to cpp file.
|
@rgrover, @andresag01 Could you review these changes ? |
…o characteristicDescriptorDiscovery
Implementation of Characteristic descriptor discovery
This is the implementation of ARMmbed/ble#105
The characteristic discovery process has been slightly modified. To discover characteristic descriptors, it is required to know the start handle and end handle of a characteristic. The discovery process handle this now.
Limitations: