-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Characteristic descriptor discovery #105
Conversation
FunctionPointerWithContext<ContextType> instances.
CharacteristicDescriptorDiscovery::DiscoveryCallback_t take a DiscoveryCallBackParam instead of just the discovered descriptor DiscoveredCharacteristicDescriptor is now a plain type. DiscoveredCharacteristic support operator== DiscoveredCharacteristic::Properties-t support operator== DiscoveredCharacteristic now include the last Gatt handle of this characteristic FunctionPointer with context call() is now const, in order to mirror std::function and call a const FunctionPointerWithContext FunctionPointerWithContext support operator == GattClient support basic characteristic descriptor discovery operations The implementation of DiscoveredCharacteristic::discoverDescriptors is now fullfiled.
- all member of CharacteristicDescriptorDiscovery::DiscoveryCallbackParams_t are now const by default - CharacteristicDescriptorDiscovery::TerminationCallbackParams_t now accept a status parameter which indicate if the operation ends properly or not - Remove DiscoveredCharacteristicDescriptor declaration from DiscoveredCharacteristic.h file - Add comparison operation to DiscoveredCharacteristic::Properties_t type - Add lastHandle member to DiscoveredCharacteristic - Add equality operator to DiscoveredCharacteristic - make FunctionPointerWithContext call operation const, so that it mirror std::function and allow to call this kind of objects to be called when they are passed by const reference - Add primitive operations to GattClient for dicovering characteristic descriptors - Fullfil DiscoveredCharacteristic::discoverDescriptors function implementation
Fix operator== in DiscoveredCharacteristic. add DiscoveredOperator::operator!= add a function to set the last handle of a DiscoveredCharacteristic on the fly
mbed os FunctionPointer implementation does not allow, yet, to use a const member function This kind of workaround is needed to use FunctionPointerWithContext class in minar
class DiscoveredCharacteristic; | ||
class DiscoveredCharacteristicDescriptor; | ||
|
||
class CharacteristicDescriptorDiscovery { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a doxygen header describing the purpose of this class. We'll need to do this for everything.
I believe it should be |
Thanks I will update all signatures. |
- isCharacteristicDescriptorsDiscoveryActive => isCharacteristicDescriptorDiscoveryActive - terminateCharacteristicDescriptorsDiscovery =>terminateCharacteristicDescriptorDiscovery
@rgrover, @andresag01 Could you review these changes ? |
+1 |
Characteristic descriptor discovery
This pull request provides:
A characteristic descriptor discovery can be made on two levels:
discoverDescriptor
member functionGattClient
low level interface