Add -Wno-unused-function to supress-warnings.cmake #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andresag01 These warnings come from nordic files or our files? If it is our files, can't we fix the sourcefile? if it is nordic, does it work if we put this cmake file in nrf51-module? |
|
They come from the nordic files, but they are included by our files. We already introduced some additional fixes for the nordic files as well. Have a look at this PR |
|
This looks good to me. +1 To answer LiYou: In many cases, the problems originate from headers in the nordic SDK, but then manifest when these headers are included in sources from ble-nrf51822 (or elsewhere). |
|
@LiyouZhou bump |
LiyouZhou
added a commit
that referenced
this pull request
Dec 8, 2015
Add -Wno-unused-function to supress-warnings.cmake
|
oh no, this was merged into 'master' |
|
I've deleted this merge from the history |
|
merged into develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rgrover @LiyouZhou