Add GCC diagnostics to suppress unused-parameter warnings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
it would be nice to add a mention of why this works. |
LiyouZhou
added a commit
that referenced
this pull request
Dec 7, 2015
Add GCC diagnostics to suppress unused-parameter warnings
|
@rgrover We need to bump patch version and republish, do you want me to do that? |
|
I thought I had done this, let me check. |
|
I just built one of the demos and it seems that the change has not been published |
|
in that case, please publish an update |
|
@rgrover @andresag01 new version published. v1.0.1 |
|
Thanks, I can see the changes now. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rgrover @LiyouZhou