Cuda safety in several headers #259
Conversation
|
Would appreciate a backport if/when we release a 3.1.6. |
There was a problem hiding this comment.
Just getting to this. All looks fine, except that there's also IMATH_HOSTDEVICE on ~Quat and ~Euler. Is there a reason you skipped those? Presumably you just don't use those classes? Could you fix those while you're at it? I'm happy to submit a separate PR if you'd prefer.
And the PR title says half.h but actually it's for several classes, right?
|
Yeah, I will fix the other as well. |
* Hide x86 intrinsics from Cuda compilation (half.h) that is a hard error when compiling for Cuda. * Avoid warnings about host/device decorations for defaulted destructors for Color3, Color4, Euler, Quat, and Shear classes -- if you define the destructor as `= default`, you shouldn't also add the IMATH_HOSTDEVICE decorator. Signed-off-by: Larry Gritz <[email protected]>
|
Fixed as requested. New description: Cuda safety in several headers
|
|
Sorry, as you suspected, the first time around I only fixed the classes where I had encountered actual warnings (because I use them directly, or at least transitively in headers I needed to include in Cuda code). |
* Hide x86 intrinsics from Cuda compilation (half.h) that is a hard error when compiling for Cuda. * Avoid warnings about host/device decorations for defaulted destructors for Color3, Color4, Euler, Quat, and Shear classes -- if you define the destructor as `= default`, you shouldn't also add the IMATH_HOSTDEVICE decorator. Signed-off-by: Larry Gritz <[email protected]>
* Hide x86 intrinsics from Cuda compilation (half.h) that is a hard error when compiling for Cuda. * Avoid warnings about host/device decorations for defaulted destructors for Color3, Color4, Euler, Quat, and Shear classes -- if you define the destructor as `= default`, you shouldn't also add the IMATH_HOSTDEVICE decorator. Signed-off-by: Larry Gritz <[email protected]>
Hide x86 intrinsics from Cuda compilation (half.h) that is a hard
error when compiling for Cuda.
Avoid warnings about host/device decorations for defaulted
destructors for Color3, Color4, Euler, Quat, and Shear classes -- if
you define the destructor as
= default, you shouldn't also add theIMATH_HOSTDEVICE decorator.
Signed-off-by: Larry Gritz [email protected]