-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load_Platform: Using ADOP_PLATFORM_MANAGEMENT_VERSION if specified #41
Conversation
Managed to build this image successfully and push it to Docker Hub. Deployed a fresh adop instance with this image successfully and the changes in the job came through properly. Going through the following test cases now:
|
Test case 1 passed successfully:
|
Test case 2 passed successfully with an invalid commit ID:
|
Test case 3 passed where I haven't set the ADOP_PLATFORM_MANAGEMENT_VERSION env variable:
|
Test case 4 passes successfully where I've set ADOP_PLATFORM_MANAGEMENT_VERSION to an invalid string:
|
Test case 5 passed successfully as well where I've set ADOP_PLATFORM_MANAGEMENT_VERSION to a blank string:
|
Performed a further test by specifying a really old commit hash and verifying that the appropriate features added afterwards were not present:
|
LGTM, thanks for the PR @nickdgriffin |
This PR enables Load_Platform to use the value of ADOP_PLATFORM_MANAGEMENT_VERSION if specified in Jenkins. This is part of Accenture/adop-platform-management#11 and maintains the current behaviour of using master (as defined in the SCM section) if the value is not provided or invalid in some way for backwards compatibility.
It follows the same rules as Accenture/adop-platform-management#11 in that it only allows a valid Git commit ID, although it goes further in that it tests if it is actually present in the repository.
I'll create the adop-docker-compose PR once the release exists.