Fixing platform jobs to a set version of adop-platform-management

[nickdgriffin]

Updating the platform jobs to use the ADOP_PLATFORM_MANAGEMENT_VERSION to know what to checkout from adop-platform-management. If ADOP_PLATFORM_MANAGEMENT_VERSION has not been set in Jenkins then it will default to the old value of "*/master".

Originally I wanted to support using tags, but there's a problem with that because whilst the jobs that consume this repository can checkout a tag Load_Platform won't be able to push the tags because Gerrit won't allow it when it is first launched and I'm not keen on running another job after the access control job has run. So for now it will support commit IDs in ADOP_PLATFORM_MANAGEMENT_VERSION.

This depends on the following PRs:

• Adding ADOP_PLATFORM_MANAGEMENT_VERSION global variable & tag pushing in Load_Platform adop-jenkins#12
• Adding ADOP_PLATFORM_MANAGEMENT_VERSION to Jenkins adop-docker-compose#61
• Removing ADOP_PLATFORM_MANAGEMENT_VERSION adop-docker-compose#185
• Load_Platform: Using ADOP_PLATFORM_MANAGEMENT_VERSION if specified adop-jenkins#41

Expected behaviour:

• If ADOP_PLATFORM_MANAGEMENT_VERSION is not present or is not a valid hash, default the ref to checkout to '*/master' as per the old functionality
• If ADOP_PLATFORM_MANAGEMENT_VERSION is added at a later date, Load_Platform will need to be run again to pickup the new changes and enable the use of the variable in the platform jobs
• If ADOP_PLATFORM_MANAGEMENT_VERSION is added at a later date, workspaces and projects will need recreating to enable the use of the variable once Load_Platform has been run

To test:

• Modify the Jenkins image version to be 0.2.7 in docker-compose.yml
• Spin it up using "--without-load"
• Edit Load_Platform to use my repo
• Run Load_Platform
• Verify all the jobs work as expected
• Add a global environment variable ADOP_PLATFORM_MANAGEMENT_VERSION in Manage Jenkins > Configure System and set it to the latest commit in my repo (i.e. the one for this PR)
• Run Load_Platform again
• Verify that the jobs are all using the correct commit ID
• Verify that all the jobs work as expected
• Change ADOP_PLATFORM_MANAGEMENT_VERSION to something else
• Run Load_Platform again
• Verify that the jobs are all using the correct commit ID (they should at least check out the specified one, whether or not they work is not the point, it will depend on what commit you pick)

To test and simulate the adop-docker-compose PR that will come from this?

• Edit docker-compose.yml to set ADOP_PLATFORM_MANAGEMENT_VERSION to the commit ID for this PR
• Spin it up using "--without-load"
• Edit Load_Platform to use my repo
• Run Load_Platform
• Verify that the jobs are all using the correct commit ID
• Verify that all the jobs work as expected

[anton-kasperovich]

@nickdgriffin as far as i see, dependencies already was merged, could you please provide an update here to understand what's left to let this PR to be merged. Thank you.

[nickdgriffin]

Going to mark this as WIP, because I think there was an issue with a similar change in Load_Platform that I haven't solved yet.

[nickdgriffin]

I think this is ready for review/testing now, I'll remove the WIP marker once someone has given it a look over and I've had a think about if there are likely to be any backwards compatibility issues.

Once this is ready to be merged I will submit a PR to change this line to the correct commit ID first so that we don't immediately break the jobs: https://github.com/Accenture/adop-docker-compose/blob/master/docker-compose.yml#L213

[nickdgriffin]

Accenture/adop-jenkins#41 has been merged, so I'll retest this soon.

[nickdgriffin]

I've finally removed the WIP flag!

I think this is ready for review, there are details above but please point out if I've left any gaping holes.

Once this has been merged I'll prepare a PR to adop-docker-compose that includes the addition of ADOP_PLATFORM_MANAGEMENT_VERSION set to the commit ID of the merge commit that results from this PR, and then the only other dependency required is Accenture/adop-docker-compose#253.

[subodh-hatkar]

Tested all mentioned scenarios with Jenkins image version 0.2.7. Load Platform works as expected. Dependency required - Accenture/adop-docker-compose#253

[dsingh07]

Test 1
Environment:

• Jenkins version 0.2.6
• Platform Management Repo: https://github.com/nickdgriffin/adop-platform-management
• ADOP_PLATFORM_MANAGEMENT_VERSION not set

Results:
Load_Platform:

All jobs were successful:

• Load_Cartridge
• Generate_Project
• Generate_Workspace
• Load_Platform

[dsingh07]

Test 2
Environment:

• Jenkins version 0.2.6
• Platform Management Repo: https://github.com/nickdgriffin/adop-platform-management
• ADOP_PLATFORM_MANAGEMENT_VERSION set to d2bd6c4
  Results:
  Load_Cartridge:
  

All jobs were successful:

• Load_Cartridge
• Generate_Project
• Generate_Workspace
• Load_Platform

[dsingh07]

Test 3
Environment:

• Jenkins version 0.2.7
• Platform Management Repo: https://github.com/nickdgriffin/adop-platform-management
• ADOP_PLATFORM_MANAGEMENT_VERSION
  • Initially unset
  • Then set to d2bd6c4
  • Then set to 6f0e1aa

Results:
Load_Cartridge config:

All jobs were successful on each run of Load_Platform once ADOP_PLATFORM_MANAGEMENT_VERSION was changed:

• Load_Cartridge
• Generate_Project
• Generate_Workspace
• Load_Platform

[dsingh07]

We are missing some jobs from the "Platform Management" folder which also need the snippet of code in there to checkout the set version:

• Job_Runner
• Load_Platform_Extension
• Load_Platform_Extension_Collection
• Setup_Pluggable_Library

[nickdgriffin]

@dsingh07 : None of those jobs use adop-platform-management, but they'll be generated from the version of adop-platform-management that is checked out when Load_Platform is run.

• Job_Runner: Pipeline job that doesn't check out a repo
• Load_Platform_Extension: Checks out the platform extension repository
• Load_Platform_Extension_Collection: Pipeline job that doesn't check out a repo
• Setup_Pluggable_Library: Checks out the pluggable library

[RobertNorthard]

Thanks @nickdgriffin. This looks good to me.

The only thing I noticed, was that upgrading from adop-jenkins 0.2.6 to 0.2.7 the Load_Platform job is not updated. To solve this, in the future, I suggest the Load_Platform job is copied as part of the adop-jenkins entry-point.

I have tested this with DOA and it's backwards compatible. Merging!