PermissionGranter should click *foreground* grant button for location #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmission request On Android Q, `"com.android.permissioncontroller:id/permission_allow_button"` isn't guaranteed to exist on permission requests where the app is requesting location permissions and only needs them for the foreground activity / service. Looks like a small enhancement is needed to detect asking for location permission and switch to matching the "foreground only" button on the presented dialog.
|
Hello @growse, so sorry for the late reply. I was going to ask you to add a regression test to verify the misbehavior, but I realized that the |
Sloy
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Done! I've merged the changes in PermissionGranterTest and enabled the Location permission test in this PR.
I'll try to make the build pass (the workflow doesn't seem to be very stable) and merge asap.
@growse Thanks a lot for the contribution! We appreciate it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android Q,
"com.android.permissioncontroller:id/permission_allow_button"isn't guaranteed to exist on permission requests where the app is requesting location permissions and only needs them for the foreground activity / service. See this example:Here,
com.android.permissioncontroller:id/permission_allow_buttondoesn't exist.Looks like a small enhancement is needed to detect asking for location permission and switch to matching the "foreground only" button on the presented dialog.