Simplify PermissionGranterTest #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alorma
approved these changes
Aug 4, 2020
|
@alorma I made some additional changes to extract some verbosity out of the tests. Do you mind checking again? |
alorma
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing tests for #356 I realized that this test class needed some improvements.
Here's what I did:
ignores_already_granted_permission. This behavior already existed but wasn't covered.grants_location_permission, because in Android Q the Location permission has different buttons. This test is broken in Q, and fixed by PermissionGranter should click *foreground* grant button for location #356fails_when_using_permissionbecause wasn't really testing the PermissionGranterRuntimePermissionActivitywithEmptyActivity. By using ActivityScenario instead of BaristaRule we can request permissions from the test without having an intermediate activity with a few buttons. Now we can request any permission from the test. Almost looks like a unit test.