Prettier 3.0 #8030
Prettier 3.0 #8030
Conversation
| console.warn('running with options', opts); | ||
| const { agoricNames, lookupPsmInstance } = await rpcTools(); | ||
| const instance = await lookupPsmInstance(opts.pair); | ||
| const offer = Offers.psm.swap(agoricNames, instance, opts); | ||
| outputExecuteOfferAction(offer); |
There was a problem hiding this comment.
sigh... indenting the whole body of the function is mildly annoying. If I saw this while writing code, I might shift things around.
| declare type Builtin = | ||
| type Builtin = |
There was a problem hiding this comment.
ugh. this code is generated by some protobuf tool. next time we run that tool (yarn generate) it's going to say declare again, IIUC. I wonder if this is a known issue upstream in the protobuf tool.
There was a problem hiding this comment.
this was generated by yarn rebuild which runs yarn generate. I put this into a separate commit, before changing Prettier: 87a2df6
| ? object.messages.map((e) => String(e)) | ||
| ? object.messages.map(e => String(e)) |
There was a problem hiding this comment.
again, this is generated code. Any clues on why our lint tools didn't complain about it when it was originally merged?
There was a problem hiding this comment.
this is the generated code after being prettiered (yarn rebuild runs prettier). The change in b46c46 is to use the same Prettier config for this package as for agoric-sdk, i.e. "arrowParens": "avoid"
There was a problem hiding this comment.
I'm confused, are you saying the codegen steps already re-format generated code?
There was a problem hiding this comment.
Yes.
Description
https://prettier.io/blog/2023/07/05/3.0.0.html
Also has a 'yarn rebuild' of cosmic-proto that was affected by #7822
uses alpha version of
eslint-plugin-prettierdue to prettier/eslint-plugin-prettier#562Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
CI