Add new required header fields for style.css #1431 #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ismail-elkorchi
suggested changes
May 15, 2020
There was a problem hiding this comment.
Thanks @truongwp for taking care of this.
Since you modified the style.scss, and style.css can you please update the rtl.css too ? This section in the contributing guide explains how to do it. Also, as I said in the comment below, the required PHP version in style.css should match the one in readme.txt
sass/style.scss
Outdated
| @@ -5,6 +5,8 @@ Author: Automattic | |||
| Author URI: https://automattic.com/ | |||
| Description: Hi. I'm a starter theme called <code>_s</code>, or <em>underscores</em>, if you like. I'm a theme meant for hacking so don't use me as a <em>Parent Theme</em>. Instead try turning me into the next, most awesome, WordPress theme out there. That's what I'm here for. | |||
| Version: 1.0.0 | |||
| Tested up to: 5,4 | |||
| Requires PHP: 5.2.4 | |||
There was a problem hiding this comment.
Suggested change
| Requires PHP: 5.2.4 | |
| Requires PHP: 5.6 |
Let's keep the required PHP version in readme.txt aligned with this one.
There was a problem hiding this comment.
Thanks. I've updated them. I have also fixed the comma in Tested up to version 😄
There was a problem hiding this comment.
I didn't see it. Good catch ! 😃
Ismail-elkorchi
approved these changes
May 15, 2020
dsgreen
added a commit
to dsgreen/_s
that referenced
this pull request
Sep 9, 2020
* 'master' of https://github.com/Automattic/_s: (92 commits) Remove PHPCS Ignore Around $content-width (Automattic#1450) Use _S_VERSION constant when enqueuing customizer.js (Automattic#1445) Update composer and node dependencies (Automattic#1444) Add missing s in languages directory name (Automattic#1442) Exclude alignment classes from RTL conversion (Automattic#1435) Add new required header fields for style.css (Automattic#1432) Remove redundant font-size declarations (Automattic#1434) Refactor navigation.js to Javascript ES6 (Automattic#1423) Delete the custom bundle script in favor of an npm package (Automattic#1433) Fix small typo (Automattic#1428) Re-organize SASS structure (Automattic#1425) Add a SASS watcher command (Automattic#1427) Remove the skip link focus fix (Automattic#1424) Replace className.indexOf with classList.contains (Automattic#1422) Use CSS grid for gallery styles (Automattic#1246) Update README.md documentation (Automattic#1419) Add a bundle script to generate a zip file for theme distribution (Automattic#1417) Update npm dependencies (Automattic#1418) Float implies the use of the block layout (Automattic#960) Use the system font stack from WP admin (Automattic#1416) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Fixes #1431