-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic styling for tel input type #606
Conversation
It looks like this commit accidentally borked indentations. |
@mikkovirenius if you could redo your PR as what you've put up wouldn't be merged with those indent issues. Personally, I don't see a need to support this. If there is demand enough, that's another matter - I'm sceptical though there will be (happy to be proved wrong). |
There really doesn't feel the demand for this, so in light of that and the current PR, I think lets close this up. |
I think this needs to be part of _s though, it's something I've found myself having to add each time I start a new theme. I'd submit a PR, but I'll give @mikkovirenius more time to refresh his PR. |
What tools you are using to compile the style.css file? If I compile sass in a expanded format, the default indentation for CSS attributes are two spaces instead of the single tab that have been used in the style.css. In addition to this empty lines are deleted from the output. Or are you running some kind of after compile script to achieve current formatting? |
I was wondering the same… |
Our mice and keyboards :) |
@pixelstrolch I found today that Sass and css are maintained separately. In other words sass files are never compiled directly into CSS. |
Apply default input styles for tel input type.