Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic styling for tel input type. See #613 #614

Closed

Conversation

mvirenius
Copy link

Add basic styling for tel input type. See #613

@obenland
Copy link
Member

Opinions? @karmatosed didn't feel like there's a need for it in #606, @philiparthurmoore suggested to merge it in #613.

@philiparthurmoore
Copy link
Collaborator

Looks good to me.

@philiparthurmoore
Copy link
Collaborator

Although part of me wonders why we have some input types and have excluded others. Was the goal here to only address input types that WordPress spits out?

@karmatosed
Copy link
Contributor

My feelings were that we should support the common ones. Even when I was freelance I can't recall the last time tel was supported in something I did, I don't think it's that common.

This all said, if we did include it we should include everyone - perhaps a slippery slope we may not want to go down yet?

@philiparthurmoore
Copy link
Collaborator

@karmatosed That's the thing. It just seems weird that some are included and some are not. Looking back as far as 7484b4c we can see that HTML5 input types started getting added in, but looking at this it's weird that some are included and some aren't. I don't understand why we just don't style input without all of these types being used? Either way, I'm fine to close this Issue out, as the following input types seem like the only ones that WordPress needs right now:

input[type="text"],
input[type="email"],
input[type="url"],
input[type="password"],
input[type="search"]

@philiparthurmoore
Copy link
Collaborator

Also, I think we're kicking off discussion for changing all of this to normalize anyway and this PR doesn't seem like it's needed at the moment.

@philiparthurmoore
Copy link
Collaborator

@mikkovirenius Sorry for having you re-submit this without accepting it. :( I'll make sure to address the original Issue before asking you to fix it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants