-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge diff between sass and css #932
Conversation
I noticed this removes some of the un-styled selectors for |
It's true that there are un-styled selectors in style.css and _menus.scss both. |
I like the idea of reordering style.css to match the compiled SASS, but you removed some of the blank lines between selectors that should be put back before this is merged. Also the explanation mark is really unnecessary in style.css and has been debated in the past. |
Thank you for your information. |
And sorry, but to clarify style.scss requires the exclamation mark to keep that comment from being stripped when compiled, but isn't needed in style.css, although I don't know that it hurts anything in style.css. Also, I'm no expert here, I've just been looking over the CSS a lot myself. |
I checked for the exclamation mark again, and I found it's necessary in style.scss to remain the comment section when compiling. |
I saw this PR and was wondering, has anyone looked into compiling the sass on underscores.me instead and removing the CSS file from this repo? The intent is that developers generally download the theme from underscores.me and not directly from this repo, correct? It already handles find/replace for theme names, couldn't it handle creating the CSS file if you don't check the "sassify" box on underscores.me? That would eliminate some of the out-of-sync issues this repo has had in the past with CSS/Sass pull requests. |
@joshmcrty #1159 #1149 is looking at automating the CSS generation which may fix the out of sync issue without needing to generate the CSS on theme generation. |
Is this still an issue? When I ran a test compile yesterday, the only differences I saw were stylistic ones because of the Sass |
This reverts commit 8e7043d.
… mark" This reverts commit 1c5a7b1.
This reverts commit ee0661c.
This reverts commit c7c1579.
This reverts commit fe7d8ea.
This reverts commit cab232e.
…s-diff * automatic/origin/master: (193 commits) Update README.md Update template hierarchy link Update year to the latest Remove extra `!` in `style.scss` Remove unnecessary ! Update screen-reader-text class. Fixing "Upload Theme" button text Add necessay backticks Change links http:// to https:// Added a note about the need to rename `_s.pot`. Travis: build against highest available PHP version Remove CSS rules for quotes - Issue Automattic#1192 Remove unused CSS. New lines and spacing. File must end with a newline character. Load WooCommerce Star fonts via inline styles. Adds WooCommerce plugin file paths. Fix column-width sass mixin. Add commas to each array value. Newline character. ...
I tried to compile with latest codes, and there seems to be one difference at a comment line break yet. Is it better to fix that? I compiled with node-sass and used options below.
|
Closing as this issue is addressed in #1391. |
When compiling Sass to CSS, there are some difference between both sources.
So, I merged to resolve conflicts.