Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: Add a specific message for a site that is too new to have a rewind status #20863

Merged
merged 7 commits into from
Aug 30, 2021
Merged

Dashboard: Add a specific message for a site that is too new to have a rewind status #20863

merged 7 commits into from
Aug 30, 2021

Conversation

cbauerman
Copy link
Contributor

@cbauerman cbauerman commented Aug 27, 2021 •
edited
Loading

Fixes 6844-gh-Automattic/jpop-issues

Changes proposed in this Pull Request:

  • Handle new site_new rewind status reason ( introduced in D66042-code ) on Jetpack Dashboard. In cases where a new user is sent immediately to the dashboard after being connected to a premium plan a timing issue could cause a message about installing VaultPress. Now it should let them know we are setting up things behind the scenes.

Screen Shot 2021-08-27 at 3 46 24 PM

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Create a new jurassic.ninja site with a premium plan and this branch
  2. Open the Jetpack wp-admin dashboard in two tabs, one with a dev console open.
  3. On the non-dev console tab connect Jetpack.
  4. Immediately reload the other tab after clicking "Authorize"
  5. Verify that the rewind network response returned unavailable and new_site reason.
  6. Verify the Backup dash status says "Your site is new and may still be preparing its backup config."

@cbauerman cbauerman added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Aug 27, 2021
@cbauerman cbauerman added this to the jetpack/10.1 milestone Aug 27, 2021
@cbauerman cbauerman self-assigned this Aug 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@cbauerman cbauerman marked this pull request as ready for review August 27, 2021 20:38
@cbauerman cbauerman changed the title Add specific message for a site that is maybe too new to have a rewind status Dashboard: Add a specific message for a site that maybe too new to have a rewind status Aug 27, 2021
@sdixon194
Copy link
Contributor

@cbauerman Heyo! Is this one ready for review?

@cbauerman
Copy link
Contributor Author

@cbauerman Heyo! Is this one ready for review?

Yup! I am afk today but unless something is drastically wrong with the PR I should be able to give it enough attention to merge before the freeze.

@cbauerman cbauerman changed the title Dashboard: Add a specific message for a site that maybe too new to have a rewind status Dashboard: Add a specific message for a site that is too new to have a rewind status Aug 30, 2021
@sdixon194 sdixon194 added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Aug 30, 2021
@sdixon194
Copy link
Contributor

Testing this out on some JN sites - it looks like it works at first, but then on refresh I get a notice about adding server credentials - is that expected?

Screen Shot on 2021-08-30 at 13:16:57

@sdixon194 sdixon194 added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Aug 30, 2021
@cbauerman
Copy link
Contributor Author

Testing this out on some JN sites - it looks like it works at first, but then on refresh I get a notice about adding server credentials - is that expected?

Yup! The message should only show up if you go to the dashboard immediately after connecting. The "add credentials" message is what it should be.

@samiff samiff self-requested a review August 30, 2021 18:07
@samiff
Copy link
Contributor

samiff commented Aug 30, 2021 •
edited
Loading

Your site is new and may still be preparing its backup config.

@cbauerman What do you think about phrasing this so it sounds a bit more sure? Maybe something like:

Backups are currently being configured for your new site.

Other than that, this tests well and looks good to me.

@cbauerman
Copy link
Contributor Author

Your site is new and may still be preparing its backup config.

@cbauerman What do you think about phrasing this so it sounds a bit more sure? Maybe something like:

Backups are currently being configured for your new site.

Other than that, this tests well and looks good to me.

The problem is we aren't necessarily sure if they have backups, which is why the message has the "maybe". It is worth noting it is pretty hard to get the message at all, you have to either be trying or in the situation described in the attached jpop issue, so whichever message we use should be fine.

@sdixon194 sdixon194 added the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 30, 2021
@sdixon194 sdixon194 merged commit cadc3e8 into master Aug 30, 2021
@sdixon194 sdixon194 deleted the add/rewind-new-site-status branch August 30, 2021 19:35
@github-actions github-actions bot removed [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 30, 2021
davidlonjon added a commit that referenced this pull request Aug 31, 2021
@davidlonjon
Merge branch 'master' into try/boost-javascript-tests-workflow
1178cf8 
* master: (34 commits)
  Fix issue templates (#20880)
  Social Icon Widget: Fix Icons Not Saving (#20862)
  Dashboard: Add a specific message for a site that is too new to have a rewind status (#20863)
  Add additional properties to WC Analytics events (#20812)
  Connection: add spinner for the "Connect" button (#20872)
  Update storybook monorepo to v6.3.7 (#20877)
  Lightweight PHPCS (#20876)
  Recommendations: Add Jetpack Product Suggestions step (#20814)
  Update babel monorepo (#20875)
  Update wordpress monorepo (#20873)
  cli: Check subprocess exit statuses in docker commands (#20861)
  Facebook Widget: Fix URL error when adding widget (#20864)
  Stats: make nudges collapsible (#20765)
  Remove temporary Newspack block override css (#20868)
  Allow ZIP uploads via Calypso (#20860)
  Sync Package Release v1.26.0 (#20870)
  Connection: remove in-place in secondary flows (#20739)
  BUILD_DIR -> BUILD_BASE in initial checks (#20857)
  E2E tests: Fix missing action for atomic workflow (#20866)
  Boost: Fix skip proxy origins to load css during critical CSS generation (#20793)
  ...
@monsieur-z monsieur-z mentioned this pull request Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiff samiff samiff approved these changes

Assignees

@cbauerman cbauerman

Labels
Admin Page React-powered dashboard under the Jetpack menu [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
jetpack/10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cbauerman @sdixon194 @samiff