Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests: Fix missing action for atomic workflow #20866

Merged
merged 9 commits into from
Aug 30, 2021
Merged

E2E tests: Fix missing action for atomic workflow #20866

merged 9 commits into from
Aug 30, 2021

Conversation

adimoldovan
Copy link
Member

@adimoldovan adimoldovan commented Aug 28, 2021 •
edited
Loading

Changes proposed in this Pull Request:

Fix broken e2e on atomic test site workflow caused by missing action. The workflow was probably added at the same time #20838 removed the action.

Jetpack product discussion

no

Does this pull request change what data or activity we track or use?

no

Testing instructions:

@adimoldovan adimoldovan self-assigned this Aug 28, 2021
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Actions GitHub actions used to automate some of the work around releases and repository management labels Aug 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Aug 28, 2021
@adimoldovan adimoldovan marked this pull request as ready for review August 28, 2021 11:08
@adimoldovan adimoldovan added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Aug 28, 2021
@adimoldovan adimoldovan requested a review from a team August 28, 2021 11:08
@adimoldovan adimoldovan enabled auto-merge (squash) August 28, 2021 11:08
@adimoldovan adimoldovan merged commit 1d93897 into master Aug 30, 2021
@adimoldovan adimoldovan deleted the fix/e2e-atomic-workflow branch August 30, 2021 06:48
@github-actions github-actions bot added this to the jetpack/10.1 milestone Aug 30, 2021
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Aug 30, 2021
davidlonjon added a commit that referenced this pull request Aug 31, 2021
@davidlonjon
Merge branch 'master' into try/boost-javascript-tests-workflow
1178cf8 
* master: (34 commits)
  Fix issue templates (#20880)
  Social Icon Widget: Fix Icons Not Saving (#20862)
  Dashboard: Add a specific message for a site that is too new to have a rewind status (#20863)
  Add additional properties to WC Analytics events (#20812)
  Connection: add spinner for the "Connect" button (#20872)
  Update storybook monorepo to v6.3.7 (#20877)
  Lightweight PHPCS (#20876)
  Recommendations: Add Jetpack Product Suggestions step (#20814)
  Update babel monorepo (#20875)
  Update wordpress monorepo (#20873)
  cli: Check subprocess exit statuses in docker commands (#20861)
  Facebook Widget: Fix URL error when adding widget (#20864)
  Stats: make nudges collapsible (#20765)
  Remove temporary Newspack block override css (#20868)
  Allow ZIP uploads via Calypso (#20860)
  Sync Package Release v1.26.0 (#20870)
  Connection: remove in-place in secondary flows (#20739)
  BUILD_DIR -> BUILD_BASE in initial checks (#20857)
  E2E tests: Fix missing action for atomic workflow (#20866)
  Boost: Fix skip proxy origins to load css during critical CSS generation (#20793)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbrr brbrr brbrr approved these changes

Assignees

@adimoldovan adimoldovan

Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Milestone
jetpack/10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@adimoldovan @brbrr