Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open in Browser button and others do not appear correctly in Dark Mode #613

Closed
msilbers opened this issue Jan 2, 2019 · 0 comments · Fixed by #619
Closed

Open in Browser button and others do not appear correctly in Dark Mode #613

msilbers opened this issue Jan 2, 2019 · 0 comments · Fixed by #619
Labels
[Type] Bug Something isn't working.

Comments

@msilbers
Copy link

msilbers commented Jan 2, 2019

Steps to reproduce

  1. Turn on Dark Mode
  2. Exit and reopen Simplenote
  3. Open a note and tap on a link

What I expected

Two things:

  1. To see the Open in Browser button
  2. For the buttons and top bar to match the colors for the app

What happened instead

The first time you tap any link after opening Simplenote in dark mode, you do not get the Open in Browser button and the coloring is wrong. If you go back to the notes list and tap any link, it will then work.

Simplenote version

1.6.7

OS version

Android 8.0.0

Screenshot / Video

First tap:
incorrect styling

After trying again:
48971461_289016515110941_615896304496672768_n
@msilbers msilbers added the [Type] Bug Something isn't working. label Jan 3, 2019
iskandergaba added a commit to iskandergaba/simplenote-android that referenced this issue Jan 9, 2019
@iskandergaba
Fixes Automattic#618 and correctly themes the bottom sheets when dark…
517a0c0 
… theme is applied. However, this does not fix Automattic#613 and the `RecyclerView` showing the sharing app buttons displays incorrect text colors THE FIRST TIME ONLY, which is caused by the same issue in Automattic#613.
@iskandergaba iskandergaba mentioned this issue Jan 9, 2019
Merged
roundhill pushed a commit that referenced this issue Jan 10, 2019
@iskandergaba @roundhill
Bugfix. Dark theme is now correctly applied in bottom sheets (#619)
aa7c3b2 
* Fixes #618 and correctly themes the bottom sheets when dark theme is applied. However, this does not fix #613 and the `RecyclerView` showing the sharing app buttons displays incorrect text colors THE FIRST TIME ONLY, which is caused by the same issue in #613.

* Changed dark background color for bottom sheets to become identical to the dark colors of the dark theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix. Dark theme is now correctly applied in bottom sheets iskandergaba/simplenote-android
1 participant
@msilbers