Bugfix. Dark theme is now correctly applied in bottom sheets #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… theme is applied. However, this does not fix Automattic#613 and the `RecyclerView` showing the sharing app buttons displays incorrect text colors THE FIRST TIME ONLY, which is caused by the same issue in Automattic#613.
|
Can the background color of the sheets match the background color we are using in the other areas of the app? I think it's |
…o the dark colors of the dark theme
|
@roundhill The requested changes are implemented for all the sheets. Check screenshots below for Info sheet. Dark
Light
|
iskandergaba
changed the title
iskandergaba
changed the title
|
Thanks @iskandergaba! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However, this does not fix #613 and the
RecyclerViewshowing the sharing app buttons displays incorrect text colors THE FIRST TIME ONLY, which is caused by the same issue in #613. For some reason, when theNoteEditorActivityis opened the first time in since opening the app, the app suddenly switches from night mode to day mode. I spent the whole day looking for the cause with no success.The theming however is fixed and I believe can be safely merged. The slight bug remaining is a result of #613. After a lot of testing, I am confident that fixing #613 will also fix it here. But that is another issue for another day/night.
Here are the results in dark theme:
Info Bottom Sheet
Share Bottom Sheet
History Bottom Sheet
@roundhill The pull request comes also with many minor code quality improvements.
Cheers!