Geologist: code quality (#4532)

* refactor outline button styles

* removed block patterns styles

* renamed mixin

blockbase/sass/blocks/_button-mixins.scss

@@ -62,3 +62,18 @@
 		}
 	}
 }
+
+//Mixins for the alternative outline style
+@mixin button-outline-hover-styles {
+	&:hover,
+	&:focus,
+	&.has-focus {
+		border-style: var(--wp--custom--button--border--style);
+		border-color: currentColor;
+		border-width: var(--wp--custom--button--border--width);
+		padding-top: var(--wp--custom--button--spacing--padding--top);
+		padding-bottom: var(--wp--custom--button--spacing--padding--bottom);
+		padding-left: var(--wp--custom--button--spacing--padding--left);
+		padding-right: var(--wp--custom--button--spacing--padding--right);
+	}
+}

blockbase/sass/blocks/_buttons-outline-style.scss

@@ -0,0 +1,41 @@
+@import 'button-mixins';
+.wp-block-button {
+	&.wp-block-button__link,
+	.wp-block-button__link {
+	   	&:not(.has-background):not(.has-text-color) {
+		   @include button-outline-hover-styles;
+	   	}
+   	}
+}
+.wp-block-file .wp-block-file__button {
+   @include button-outline-hover-styles;
+}	
+
+.wp-block-search {
+   	&.wp-block-search__button-inside .wp-block-search__inside-wrapper .wp-block-search__button,
+   	.wp-block-search__button {
+	   @include button-outline-hover-styles;
+   	}
+}
+
+.wp-block-post-comments {
+   	input[type="submit"], .reply a {
+	   @include button-outline-hover-styles;
+   	}
+}
+
+//NOTE: Double-classed to raise specificity above parent theme's outline hover styles
+//as an alternative to !important.  Only needed for the editor.
+.wp-block-button.wp-block-button.is-style-outline {
+	&.wp-block-button__link,
+	.wp-block-button__link {
+	   &:not(.has-background):not(.has-text-color) {
+		   &:hover,
+		   &:focus,
+		   &.has-focus {
+			   color: var(--wp--custom--button--color--background);
+			   background-color: var(--wp--custom--button--color--text);
+		   	}
+	   	}
+   	}
+}