Geologist: code quality #4532
Merged
Geologist: code quality #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR refactors the outline button styles into blockbase so we don't need to repeat the code for every child theme that wants to use these kinds of buttons. We are also removing the block patterns css from Geologist.
To test this check that the buttons still look the same on all child themes. While I was working on this I built all children and only the block patterns css is being removed from Geologist, the rest of the child themes' css are unaffected.
After looking at the rest of the code I think we can remove some css from the post comments block that is already on blockbase, I will be looking into that tomorrow.
Related issue(s):
Partially addresses #4531