Quadrat: hide query pagination if there's no pagination #4272
Conversation
jffng
force-pushed
the
try/remove-extra-pagination-div
branch
from
af0fb8d to
ce96000
Compare
|
I believe this is ready for a review. To test, check out this PR and make sure pagination is appearing correctly. Then, adjust your site so that fewer than five posts exists. No pagination container or dividing line should be rendered. |
| @@ -1,6 +1,6 @@ | |||
| <!-- wp:template-part {"slug":"header"} /--> | |||
|
|
|||
| <!-- wp:query {"tagName":"main","layout":{"inherit":true},"queryId":1,"query":{"perPage":5,"offset":0,"postType":"post","categoryIds":[],"tagIds":[],"order":"desc","orderBy":"date","author":"","search":"","sticky":"","inherit":true}} --> | |||
| <!-- wp:query {"tagName":"main","layout":{"inherit":true},"queryId":1,"query":{"perPage":5,"offset":0,"postType":"post","categoryIds":[],"tagIds":[],"order":"desc","orderBy":"date","author":"","search":"","sticky":"","inherit":false}} --> | |||
There was a problem hiding this comment.
I had to adjust inherit to false for pagination to work at all... This matches skatepark's index query too: https://github.com/Automattic/themes/blob/trunk/skatepark/block-templates/index.html#L6
|
Should we do this on search.html and query-diamond.php too? |
|
This looks fine to me locally but wpcom still doesn't have the GB change |
|
I see this on dotcom, don't know if dotcom has the fix or not |
Oh yeah, I will update there too.
Ah I see, shall we hold off on merging until the fix is there? |
|
Yeah, we talked about holding this one until It lands since the bug is very minor |
|
We should do this for all themes: #4805 |
Changes proposed in this Pull Request:
This change relies on
WordPress/gutenberg#33635WordPress/gutenberg#35092To test, activate this PR on a completely empty site or one with less than five posts ( so no pagination appears ).
Related issue(s):
Solves #4268