Query Pagination: do not render pagination container if there's no pagination #33635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
added
the
[Block] Query Pagination
jffng
commented
Jul 22, 2021
| function render_block_core_query_pagination( $attributes, $content ) { | ||
| $wrapper_attributes = get_block_wrapper_attributes(); | ||
|
|
||
| if ( empty( $content ) || ctype_space( $content ) ) { |
There was a problem hiding this comment.
For some reason the $content is a long string of whitespace when it's empty, so I added the ctype_space condition.
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
scruffian
force-pushed
the
fix/query-pagination-empty-render
branch
2 times, most recently
from
e002f43 to
2f73b6b
Compare
|
The problem I am seeing with this is that when the block has already been saved it contains content like this:
Do we need to check for $content at all, or can we always just do a server rendering? |
|
I see what you mean. But if we don't check $content, how else could we avoid rendering an empty container? |
|
Hmm. I guess the alternative is to check for |
scruffian
force-pushed
the
fix/query-pagination-empty-render
branch
from
2f73b6b to
6b32739
Compare
|
Thinking about this some more, I think it's good. If won't deal with blocks that have already been saved, but it will work for new blocks. |
scruffian
approved these changes
Aug 25, 2021
7 tasks
|
Closing in favor of #35092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a render callback to the query pagination block. This way, the pagination container element is only rendered if pagination exists.
I think rendering an empty container in most cases is harmless, but is it better to actually not add anything to the DOM if there isn't content present? There are probably other cases where this happens in FSE blocks..
This is an attempt to solve Automattic/themes#4268 where we style the wrapper only when pagination is present.
How has this been tested?
Screenshots
Types of changes
Bug fix?
Checklist:
*.native.jsfiles for terms that need renaming or removal).