General: move VaultPress class to own file & add PHP53 shortcircuit #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
force-pushed
the
fix/php53-dep
branch
2 times, most recently
from
01b8af3 to
8423e40
Compare
dereksmart
reviewed
Jun 12, 2019
dereksmart
reviewed
Jun 12, 2019
jeherve
added a commit
that referenced
this pull request
Jun 12, 2019
jeherve
added a commit
that referenced
this pull request
Jun 12, 2019
Fixes #15
- Moving the main VaultPress class to its own class allows us to move all PHP 5.3+ code out of the plugin's entry point, vaultpress.php
- In that plugin's entry point, we now check the PHP version in use on the site, and pause the VaultPress plugin (i.e. stop loading it) if you are running an old version of PHP.
dereksmart
approved these changes
Jun 12, 2019
jeherve
added a commit
that referenced
this pull request
Jun 12, 2019
jeherve
added a commit
that referenced
this pull request
Jun 12, 2019
jeherve
added a commit
that referenced
this pull request
Jul 12, 2019
* General: move VaultPress class back to main plugin file Partially reverts #16 * Logo: move to separate file. This will avoid us using PHP5.3+ syntax in the plugin's entry file, thus not fataling PHP 5.2 sites.
jeherve
added a commit
that referenced
this pull request
Jul 12, 2019
* General: move VaultPress class back to main plugin file Partially reverts #16 * Logo: move to separate file. This will avoid us using PHP5.3+ syntax in the plugin's entry file, thus not fataling PHP 5.2 sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
To test