General: revert to using a big entry file, with only the Logo moved to a different file #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially reverts #16
This will avoid us using PHP5.3+ syntax in the plugin's entry file, thus not fataling PHP 5.2 sites.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
dereksmart
approved these changes
Jul 12, 2019
jeherve
added a commit
that referenced
this pull request
Jul 12, 2019
* General: move VaultPress class back to main plugin file Partially reverts #16 * Logo: move to separate file. This will avoid us using PHP5.3+ syntax in the plugin's entry file, thus not fataling PHP 5.2 sites.
|
Cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #16; it moves the
VaultPressclass back to main plugin file. It also moves the Jetpack Logo (which relies on a Composer package and is loaded using PHP5.3+ syntax) to its own file, so the main entry file does not include any PHP5.3+ syntax that would cause fatals on sites running PHP 5.2 (as pointed out in #15).To test
Load the VaultPress dashboard. The logo should appear in the footer, without any errors.