Fix nth-last-child styles on virtualizing layouts #10055
Conversation
Will hopefully make it a bit more obvious if it breaks in future: previously it was easier to miss as both `nth-child` and `nth-last-child` changed the foreground.
And a passing test for `nth-child` selector.
|
You can test this PR using the following package version. |
| _provider.TotalCountChanged += TotalCountChanged; | ||
| } | ||
|
|
||
| protected override void Deinitialize() | ||
| { | ||
| _provider.ChildIndexChanged -= ChildIndexChanged; |
There was a problem hiding this comment.
- Do we even need to subscribe on TotalCountChanged when it's not reversed?
- TotalCountChanged is not unsubscribed on Deinitialize
There was a problem hiding this comment.
- I think this depends on the answer to the question in the PR description
- This too, really..,
|
@maxkatz6 ping - still waiting for your thoughts on the question in the PR description. |
|
You can test this PR using the following package version. |
I don't have strong preference here. Having a single event makes sense in general. If keep two different events, then total count can be added to the TotalCountChanged event args. So TryGetTotalCount/GetChildIndex calls can be basically eliminated except of initial read. |
Merge it into existing `IChildIndexProvider.ChildIndexChanged` event.
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
What does the pull request do?
After #9677 was merged,
nth-last-childstyles stopped working inListBoxdue to the problem described here.This PR modifies the
IChildIndexProviderAPI to add the following:ChildIndexChangedEventArgsTotalCountChangedevent was addedIt also removes the hack in
ItemsControlwhich was used to work around this problem.Questions
I've marked this PR as draft for the moment because I'm not sure about one thing:
We now have two events on
IChildIndexProviderbut they will always be subscribed by the same object. Maybe we need to merge the two events into a single event with anActionproperty which would be an enum of:ChildIndexChangedTotalCountChangedBreaking changes
The
IChildIndexProviderinterface has changed. Shouldn't be much of a problem as it's unlikely to be client-implemented.Fixed issues
Fixes #9997