Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nth-last-child styles on virtualizing layouts #10055

Merged
merged 11 commits into from
Feb 23, 2023
Merged

Fix nth-last-child styles on virtualizing layouts #10055

merged 11 commits into from
Feb 23, 2023

Commits on Jan 19, 2023

  1. Make nth-last-child style change background. 

    Will hopefully make it a bit more obvious if it breaks in future: previously it was easier to miss as both `nth-child` and `nth-last-child` changed the foreground.
    @grokys
    grokys committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    9de82b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Add failing test for #9997. 

    And a passing test for `nth-child` selector.
    @grokys
    grokys committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    649e4fc View commit details
    Browse the repository at this point in the history

  2. Fix new index calculation.

    @grokys
    grokys committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    2ef91ff View commit details
    Browse the repository at this point in the history

  3. Added index to ChildIndexChangedEventArgs.

    @grokys
    grokys committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    8861f62 View commit details
    Browse the repository at this point in the history

  4. Added IChildIndexProvider.TotalCountChanged.

    @grokys
    grokys committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    f289099 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Clarify this code.

    @grokys
    grokys committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    a29bfda View commit details
    Browse the repository at this point in the history

  2. Remove hack from ItemsControl.

    @grokys
    grokys committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    b127453 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Merge branch 'master' into fixes/9997-nth-last-child-itemscontrol

    @grokys
    grokys committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    e3719ed View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Remove TotalCountChanged. 

    Merge it into existing `IChildIndexProvider.ChildIndexChanged` event.
    @grokys
    grokys committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d98467c View commit details
    Browse the repository at this point in the history

  2. Only subscribe to event when necessary.

    @grokys
    grokys committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    87dc9bb View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Merge branch 'master' into fixes/9997-nth-last-child-itemscontrol

    @maxkatz6
    maxkatz6 authored Feb 23, 2023
    Configuration menu
    Copy the full SHA
    5849167 View commit details
    Browse the repository at this point in the history