-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify functionality of super and hyperrun #871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Caveat: sometimes the saved superurn with
_combining_subruns = True
and_combining_subruns = False
are different when the combined subruns under_combining_subruns = False
has "long range force", like the example intest_only_combining_superruns
. However, this is not usually the case in real data processing. But users need to be clear about what they are doing.Sorry for the back-and-forth, after this PR:
run_id
starts with_
and_combining_subruns
isTrue
whenget_iter
, the context will make thetargets
and combine them according to the run metadata.run_id
starts with_
and_combining_subruns
isFalse
whenget_iter
, the context will make the subruns'targets
untill the dependency tree starts to support superrun (allow_superrun
isTrue
). The first plugin whoseallow_superrun
isTrue
will merge thedepends_on
of subruns according to the run metadata, and then the following processing will all be done in the scope of superrun.To achieve these, the main change is that we handle superrun, especially the subruns in
Plugin
, notRechunker
anymore.Also, completely deprecate
storage_converter
.Can you briefly describe how it works?
Change the logic in
get_components
.Can you give a minimal working example (or illustrate with a figure)?
The most important test might be
test_only_combining_superruns
andtest_loaders_and_savers
inTestSuperRuns
. Please look at them.When
_combining_subruns
isTrue
, context will process each subrun to the targeteddata_type
, and then combine subruns.Please include the following if applicable:
Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).