Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
To solve the caveat in #871, this PR saves the
combining
(True or False) instrax.DataKey
to distinguish whether superrun is in only combining mode.Also, change
_combining_subruns
tocombining
because it will be an argument frequently used.Can you briefly describe how it works?
PR first simplifies
get_components
and adds another attributecombining
instrax.DataKey
.Can you give a minimal working example (or illustrate with a figure)?
Please find the example at
test_only_combining_superruns
modified by this PR.Please include the following if applicable:
Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).