Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combining into the DataKey #886

Merged
merged 7 commits into from
Aug 31, 2024
Merged

Add combining into the DataKey #886

merged 7 commits into from
Aug 31, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Aug 30, 2024

What is the problem / what does the code in this PR do

To solve the caveat in #871, this PR saves the combining (True or False) in strax.DataKey to distinguish whether superrun is in only combining mode.

Also, change _combining_subruns to combining because it will be an argument frequently used.

Can you briefly describe how it works?

PR first simplifies get_components and adds another attribute combining in strax.DataKey.

Can you give a minimal working example (or illustrate with a figure)?

Please find the example at test_only_combining_superruns modified by this PR.

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

coveralls commented Aug 30, 2024

Coverage Status

coverage: 90.86% (+0.05%) from 90.812%
when pulling 92120cb on combining_into_lineage
into 5e5c620 on master.

@dachengx dachengx changed the title Save _combining_subruns to lineage Add combine into the DataKey Aug 31, 2024
@dachengx dachengx changed the title Add combine into the DataKey Add combining into the DataKey Aug 31, 2024
@dachengx dachengx marked this pull request as ready for review August 31, 2024 11:15
@dachengx dachengx merged commit 10f7ef6 into master Aug 31, 2024
8 checks passed
@dachengx dachengx deleted the combining_into_lineage branch August 31, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants