Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website Bug]: Latest bicep module version not shown due to sort ordering issue #1181

Closed
1 task done
ktremain opened this issue Jul 10, 2024 · 6 comments · Fixed by #1182
Closed
1 task done

[Website Bug]: Latest bicep module version not shown due to sort ordering issue #1181

ktremain opened this issue Jul 10, 2024 · 6 comments · Fixed by #1182
Assignees
Labels
Needs: External Changes ⚒️ When an issue/PR requires changes that are outside of the control of the module. e.g. to an RP. Type: CI 🚀 This issue is related to the AVM CI Type: Hygiene 🧹 things related to testing, issue triage etc. Type: Question/Feedback 🙋 Further information is requested or just some feedback

Comments

@ktremain
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

On the AVM website, In the Resource Module index for Bicep (https://azure.github.io/Azure-Verified-Modules/indexes/bicep/bicep-resource-modules/) the latest badge does not appear to show the most recent version when it exceeds x.9.x
Example:
image
The storage module is currently at 0.11.0:
image

@ktremain ktremain added Needs: Triage 🔍 Maintainers need to triage still Type: Question/Feedback 🙋 Further information is requested or just some feedback labels Jul 10, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Issue Triage Jul 10, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

@ktremain
Copy link
Author

@jtracey93

@jtracey93 jtracey93 added Type: Hygiene 🧹 things related to testing, issue triage etc. Type: CI 🚀 This issue is related to the AVM CI labels Jul 10, 2024
@jtracey93 jtracey93 self-assigned this Jul 10, 2024
@jtracey93
Copy link
Contributor

Thanks @ktremain ill take a look into this now.

Did you say this also happens in vscode intellisense for the same modules?

@ktremain
Copy link
Author

Thanks @ktremain ill take a look into this now.

Did you say this also happens in vscode intellisense for the same modules?

yes, also affects the Bicep VSCode extension:
image

@jtracey93
Copy link
Contributor

Hey @ktremain, I have fixed the AVM website. VSCode i will be raising an issue on the bicep repo as the bicep VScode extension is at fault here and I have spoken to the PG to confirm this

@jtracey93 jtracey93 reopened this Jul 11, 2024
@jtracey93 jtracey93 added Needs: External Changes ⚒️ When an issue/PR requires changes that are outside of the control of the module. e.g. to an RP. and removed Needs: Triage 🔍 Maintainers need to triage still labels Jul 11, 2024
jtracey93 added a commit to Azure/bicep-registry-modules that referenced this issue Jul 15, 2024
…antic version (latest last) (#2711)

## Description

Fix `moduleIndex.json` generation to order tags for module by semantic
version (latest last)

Part of fix for
Azure/Azure-Verified-Modules#1181 and
Azure/bicep#14530

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
| [![.Platform - Publish
[moduleIndex.json]](https://github.com/jtracey93/bicep-registry-modules/actions/workflows/platform.publish-module-index-json.yml/badge.svg?branch=fix-tags-version-ordering-moduleindex)](https://github.com/jtracey93/bicep-registry-modules/actions/workflows/platform.publish-module-index-json.yml)
|

## Evidence of local testing

CI test wont pass as no access to storage account but artifacts and
local running/testing of script produces the correct results

**before:**

![image](https://github.com/user-attachments/assets/de75ef40-89d5-4ba5-934b-f11f1cb780e3)

**after:**

![image](https://github.com/user-attachments/assets/c2cfc124-5563-4163-92cb-ae59edb6eaf9)

**local test run ending**

![image](https://github.com/user-attachments/assets/0aff55f5-f680-4a3c-a123-d847e59e641c)

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@jtracey93
Copy link
Contributor

This is fixed in the latest bicep release https://github.com/Azure/bicep/releases/tag/v0.31.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: External Changes ⚒️ When an issue/PR requires changes that are outside of the control of the module. e.g. to an RP. Type: CI 🚀 This issue is related to the AVM CI Type: Hygiene 🧹 things related to testing, issue triage etc. Type: Question/Feedback 🙋 Further information is requested or just some feedback
Projects
Development

Successfully merging a pull request may close this issue.

2 participants