Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bicep Module Latest Version Display Ordering #1182

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

jtracey93
Copy link
Contributor

Overview/Summary

Fixes the bicep modules latest version feature we added to ensure it always shows the latest version and not just relying on ordering of the module tags array from the MCR API, as this does not order them correctly (unlike the terraform registry - hence no changes needed for terraform)

This PR fixes/adds/changes/removes

  1. Fixes [Website Bug]: Latest bicep module version not shown due to sort ordering issue #1181

Breaking Changes

None, just docs

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jtracey93 jtracey93 requested a review from a team as a code owner July 10, 2024 19:44
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jul 10, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

Copy link
Contributor

@mbilalamjad mbilalamjad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 0360551 into main Jul 10, 2024
4 checks passed
@jtracey93 jtracey93 deleted the users/jtracey93/fix-version-ordering branch July 10, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website Bug]: Latest bicep module version not shown due to sort ordering issue
2 participants