This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Optimize commons files - configurable.rb & default.rb #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarangan12 the CI is failing with all but the latest runtime due to the changes only being in the latest runtime, right? |
|
@devigned Yes. The latest runtime has the required code changes while the published ones don't |
devigned
approved these changes
Nov 8, 2017
veronicagg
reviewed
Nov 8, 2017
| @@ -70,7 +70,7 @@ | |||
|
|
|||
| load_balancing_rule = LoadBalancingRule.new | |||
| load_balancing_rule.name = load_balancing_rule_name | |||
| frontend_ip_configuration_sub_resource = MsRestAzure::SubResource.new | |||
There was a problem hiding this comment.
this change is not related to the PR, right? I believe it's related to #1106, where should have this been caught when the other PR changes happened?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the process of copying configurable.rb and default.rb to all gems. Moved the files to MsRestAzure and optimized the code.
@devigned @veronicagg @salameer Please review and approve.