Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Optimize commons files - configurable.rb & default.rb #1111

Merged
merged 3 commits into from
Nov 8, 2017
Merged

Optimize commons files - configurable.rb & default.rb #1111

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65233c6
Optimize usage of configurable & default
sarangan12 Nov 7, 2017
1944af7
Regen all SDK versions and profiles
sarangan12 Nov 7, 2017
ded8f97
Minor change
sarangan12 Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions management/azure_mgmt_network/spec/2017-09-01/load_balancers_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@

load_balancing_rule = LoadBalancingRule.new
load_balancing_rule.name = load_balancing_rule_name
frontend_ip_configuration_sub_resource = MsRestAzure::SubResource.new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is not related to the PR, right? I believe it's related to #1106, where should have this been caught when the other PR changes happened?

frontend_ip_configuration_sub_resource = SubResource.new
frontend_ip_configuration_sub_resource.id =
get_child_lb_resource_id(@resource_helper.network_client.subscription_id, @resource_group.name,
lb_name, 'FrontendIPConfigurations', frontend_ip_config_name)
Expand All @@ -80,12 +80,12 @@
load_balancing_rule.backend_port = 80
load_balancing_rule.enable_floating_ip = false
load_balancing_rule.idle_timeout_in_minutes = 15
backend_address_pool_sub_resource = MsRestAzure::SubResource.new
backend_address_pool_sub_resource = SubResource.new
backend_address_pool_sub_resource.id =
get_child_lb_resource_id(@resource_helper.network_client.subscription_id, @resource_group.name,
lb_name, 'backendAddressPools', backend_address_pool_name)
load_balancing_rule.backend_address_pool = backend_address_pool_sub_resource
probe_sub_resource = MsRestAzure::SubResource.new
probe_sub_resource = SubResource.new
probe_sub_resource.id =
get_child_lb_resource_id(@resource_helper.network_client.subscription_id, @resource_group.name,
lb_name, 'probes', probe_name)
Expand Down