Expected fix for LeaseID missing not present in v0.12.0

[eccles]

Which version of the SDK was used?

0.12.0

Which platform are you using? (ex: Windows, Linux, Debian)

Linux

What problem was encountered?

Incorrect version tagged upstream - expected fix #230 not implemented

How can we reproduce the problem in the simplest way?

go get v0.12.0 and inspect chunkwriting.go - expecetd fix from #230 not present in line 187

Have you found a mitigation/solution?

No

Some explanation

Thanks for the release - however the tagging has gone awry - I change my go.mod file to:

github.com/Azure/azure-storage-blob-go v0.12.0

and inspection of my go cache:

vi /opt/go/pkg/mod/github.com/!azure/[email protected]/azblob/chunkwriting.go

shows the change has not been applied.

187 _, err := c.to.StageBlock(c.ctx, chunk.id, bytes.NewReader(chunk.buffer), LeaseAccessConditions{}, nil, c.o.ClientProvidedKeyOptions)

If I pull repo directly using git clone and inspect that all looks good:

paul@paul-Precision-7530:~/git/azure-storage-blob-go$ git log
commit 6df5d9a (HEAD -> master, tag: v0.12.0, origin/master, origin/HEAD)
Merge: 456ab47 559b75b
Author: Mohit Sharma [email protected]
Date: Wed Dec 9 17:40:48 2020 +0530

Merge pull request #235 from Azure/dev

Release v0.12.0
commit 559b75b (origin/dev)
Author: Mohit Sharma [email protected]
Date: Wed Dec 9 12:49:08 2020 +0530

v0.12.0 Release change logs (#231)

• v0.12.0 Release ChangeLogs & BreakingChanges

• Updated changelogs

• Added mmf changes in ChangeLog.md
  commit 0c35e97
  Author: Mohit Sharma [email protected]
  Date: Fri Nov 20 23:41:19 2020 +0530

Fixed #230 (#232)
and the fix is in:

186 _, err := c.to.StageBlock(c.ctx, chunk.id, bytes.NewReader(chunk.buffer), c.o.AccessConditions.LeaseAccessConditions, nil, c.o.ClientProvidedKeyOptions)

[eccles]

Speculation: the merge for the addition of c.o.ClientProvidedKeyOptions overwrote the change for c.o.AccessConditions.LeaseAccessConditions

[mohsha-msft]

Hey @eccles ,

Thanks for reaching out!
Please take a look here

Can you please try to do a go get github.com/Azure/azure-storage-blob-go again followed by go mod tidy?

[eccles]

Tried it but still no change - the code in /opt/go/pkg/mod/github.com/!azure/[email protected]/azblob/chunkwriting.go (which is in my gocache) is still incorrect.

[mohsha-msft]

hey @eccles ,

The changes which you mentioned has already been merged. Can you explain what issue you are facing now?

[eccles]

To summaru=ise the state of the repo looks correct but when I do a go get I get a versuion without the #230 change which I need.
I have no explanation of why this is so

I have tried @dev which gives me the v0.10.1-0.20201209071908-559b75bbc31d which is no good.
I have tried @6df5d9af221d67aa1173ad090 which has the same problem..

[eccles]

go list -m -json github.com/Azure/[email protected]
{
"Path": "github.com/Azure/azure-storage-blob-go",
"Version": "v0.12.0",
"Time": "2020-11-21T18:08:49Z",
"Dir": "/opt/go/pkg/mod/github.com/!azure/[email protected]",
"GoMod": "/opt/go/pkg/mod/cache/download/github.com/!azure/azure-storage-blob-go/@v/v0.12.0.mod",
"GoVersion": "1.15"
}

The time looks a little suspicious... or maybe not

[h-no]

I was curious and had a look myself.

I checkout out the repo.

❯ git show
commit 6df5d9af221d67aa1173ad09073ef95c872beda0 (HEAD -> master, tag: v0.12.0, origin/master, origin/HEAD)
Merge: 456ab47 559b75b
Author: Mohit Sharma <[email protected]>
Date:   Wed Dec 9 17:40:48 2020 +0530

    Merge pull request #235 from Azure/dev

    Release v0.12.0

Then diffed the entire tree using Meld with my go mod cache.
Ended up with the following diff:

❯ diff ~/.go/pkg/mod/github.com/\!azure/[email protected]/azblob/chunkwriting.go /github.com/Azure/azure-storage-blob-go/azblob/chunkwriting.go
186,187c186
<
< 	_, err := c.to.StageBlock(c.ctx, chunk.id, bytes.NewReader(chunk.buffer), LeaseAccessConditions{}, nil, c.o.ClientProvidedKeyOptions)
---
> 	_, err := c.to.StageBlock(c.ctx, chunk.id, bytes.NewReader(chunk.buffer), c.o.AccessConditions.LeaseAccessConditions, nil, c.o.ClientProvidedKeyOptions)

So the bytes that gets downloaded by go is not what's in the repo.

Could this be the reason why I got the checksum mismatch in this issue that you closed: #237

[h-no]

So to summarize, @eccles I experience the same as you.

[bcmills]

It looks like the v0.12.0 tag was moved at some point:

$ GOPROXY=direct go get -d github.com/Azure/azure-storage-blob-go@6df5d9af221d67aa1173ad09073ef95c87
2beda0
go: downloading github.com/Azure/azure-storage-blob-go v0.12.0
go get github.com/Azure/azure-storage-blob-go@6df5d9af221d67aa1173ad09073ef95c872beda0: github.com/Azure/[email protected]: verifying module: checksum mismatch
        downloaded: h1:LEu0WO1uxAkeJFuNTZR+xxUpIoRUwOXgA2ipS798Ycc=
        sum.golang.org: h1:7bFXA1QB+lOK2/ASWHhp6/vnxjaeeZq6t8w1Jyp0Iaw=
SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.
For more information, see 'go help module-auth'.

As a workaround, you can instead refer to that commit by the pseudo-version v0.11.1-0.20201209121048-6df5d9af221d, which is what it would have been called prior to the erroneous tag being applied:

$ go get -d github.com/Azure/[email protected]
go: downloading github.com/Azure/azure-storage-blob-go v0.11.1-0.20201209121048-6df5d9af221d

$

[bcmills]

Probably the best fix going forward would be to retract v0.12.0 (see golang/go#24031 (comment)) and tag a new v0.12.1 at the desired commit.

[eccles]

@bcmills thanx - @mohsha-msft ?

[vangent]

@mohsha-msft any chance for a 12.1 tag soon?

[eccles]

This issue has become a matter of urgency for us - any chance of a 0.12.1 release which is properly tagged?

[eccles]

I can confirm that using v0.11.1-0.20201209121048-6df5d9af221d as suggested by @bcmills does apparently work.

[ondrejbudai]

The workaround works for me too. I would love to see 0.12.1 released though.

[zezha-msft]

That's quite a strange issue, we apologize for the inconvenience.

A new release just went out: https://github.com/Azure/azure-storage-blob-go/releases/tag/v0.13.0

Please let us know if you are still encountering problems.

[eccles]

HI - I can confirm that this is fixed by v0.13.0