Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/azblob: Fix azure-storage-blob-go checksum #2935

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented Dec 18, 2020

The tag for this module got yanked and now checksums are failing. Pin
the version to the pseudo-version as described in
Azure/azure-storage-blob-go#236 (comment).

@google-cla google-cla bot added the cla: yes Google CLA has been signed! label Dec 18, 2020
@stanhu stanhu force-pushed the sh-fix-azure-storage-blob-gomod-sum branch 2 times, most recently from c595d0c to 78768e5 Compare December 18, 2020 08:00
The tag for this module got yanked and now checksums are failing. Pin
the version to the pseudo-version as described in
Azure/azure-storage-blob-go#236 (comment).
@stanhu stanhu force-pushed the sh-fix-azure-storage-blob-gomod-sum branch from 78768e5 to 09e298f Compare December 18, 2020 17:02
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #2935 (2f9beec) into master (48f2d4c) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
+ Coverage   69.17%   69.28%   +0.11%     
==========================================
  Files         110      110              
  Lines       11451    11451              
==========================================
+ Hits         7921     7934      +13     
+ Misses       2882     2868      -14     
- Partials      648      649       +1     
Impacted Files Coverage Δ
blob/s3blob/s3blob.go 89.47% <0.00%> (+0.52%) ⬆️
pubsub/rabbitpubsub/rabbit.go 80.68% <0.00%> (+0.75%) ⬆️
internal/retry/retry.go 100.00% <0.00%> (+7.69%) ⬆️
server/health/sqlhealth/sqlhealth.go 78.37% <0.00%> (+21.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f2d4c...2f9beec. Read the comment docs.

@stanhu
Copy link
Contributor Author

stanhu commented Dec 22, 2020

@vangent Would you mind merging this? I'm blocked on upgrading go-cloud due to this dependency issue.

@vangent vangent merged commit 5094f54 into google:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants