Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publish_images Action pushes images with the right version #67

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

mainred
Copy link
Member

@mainred mainred commented Aug 1, 2022

What type of PR is this?

What this PR does / why we need it:

Currently, publish_images Github Action constantly pushes images to the GitHub registry with version v0.1.0, which is correct. Fix this by:

  • push images to the registry with the main version when the trigger is by the main branch push
  • push images to the registry with the created tag when the trigger is by a tag creation

Meanwhile, we changed the makefile to modify the image version to a short-versioned commit SHA-1 hash instead of the constant v0.1.0

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@mainred mainred requested review from michaelawyu and zhiying-lin and removed request for michaelawyu and zhiying-lin August 1, 2022 04:24
@mainred
Copy link
Member Author

mainred commented Aug 1, 2022

This is based on the change of Azure/fleet#203

@mainred mainred merged commit 6a25701 into Azure:main Aug 1, 2022
@mainred mainred deleted the push-image-to-main branch August 1, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants