chore: add fleet networking rules #203
Conversation
| APIGroups: []string{""}, | ||
| Resources: []string{"events"}, | ||
| } | ||
| FleetNetworkRule = rbacv1.PolicyRule{ |
There was a problem hiding this comment.
@ryanzhang-oss , I did not add work api here because we are reusing module path the origin upstream sigs.k8s.io/work-api instead of like go.goms.io/work-api?
https://github.com/Azure/k8s-work-api/blob/v0.1.0/go.mod
There was a problem hiding this comment.
sure, I will add that later.
Makefile
Outdated
| else | ||
| HUB_AGENT_IMAGE_VERSION ?= $(TAG) | ||
| MEMBER_AGENT_IMAGE_VERSION ?= $(TAG) | ||
| REFRESH_TOKEN_IMAGE_VERSION ?= $(TAG) |
There was a problem hiding this comment.
I don't think we have the case to publish images with different versions at the same time.
There was a problem hiding this comment.
not her but might be needed in the publish CI
| APIGroups: []string{""}, | ||
| Resources: []string{"events"}, | ||
| } | ||
| FleetNetworkRule = rbacv1.PolicyRule{ |
There was a problem hiding this comment.
sure, I will add that later.
Makefile
Outdated
| else | ||
| HUB_AGENT_IMAGE_VERSION ?= $(TAG) | ||
| MEMBER_AGENT_IMAGE_VERSION ?= $(TAG) | ||
| REFRESH_TOKEN_IMAGE_VERSION ?= $(TAG) |
There was a problem hiding this comment.
not her but might be needed in the publish CI
Makefile
Outdated
| @@ -1,11 +1,15 @@ | |||
| REGISTRY ?= ghcr.io | |||
| KIND_IMAGE ?= kindest/node:v1.23.3 | |||
| ifndef TAG | |||
| HUB_AGENT_IMAGE_VERSION ?= $(shell git rev-parse --short=7 HEAD) | |||
| else | |||
There was a problem hiding this comment.
do we need an else here?
it seems that the below needs to be set in any case
mainred
force-pushed
the
add-fleet-networking-rules
branch
from
cb08336
to
380b311
Compare
Description of your changes
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer