Skip to content

Commit

Permalink
Fixing tests due to directory clean-up
Browse files Browse the repository at this point in the history
Disabling UI tests that require MFA until we find a solution to #2716
  • Loading branch information
jmprieur committed Mar 24, 2024
1 parent 689bfcd commit b705423
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion tests/E2E Tests/TokenAcquirerTests/TokenAcquirer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ private static async Task CreateGraphClientAndAssert(TokenAcquirerFactory tokenA
.GetAsync(o => o.Options
.WithAppOnly()
.WithAuthenticationScheme(s_optionName));
Assert.True(users!=null && users.Value!=null && users.Value.Count >= 56);
Assert.True(users!=null && users.Value!=null && users.Value.Count >0);

// Alternatively to calling Microsoft Graph, you can get a token acquirer service
// and get a token, and use it in an SDK.
Expand Down
4 changes: 2 additions & 2 deletions tests/E2E Tests/WebAppUiTests/TestingWebAppLocally.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ public TestingWebAppLocally(ITestOutputHelper output)
_output = output;
}

[Fact]
[Fact (Skip = "https://github.com/AzureAD/microsoft-identity-web/issues/2716")]
[SupportedOSPlatform("windows")]
public async Task ChallengeUser_MicrosoftIdFlow_LocalApp_ValidEmailPassword()
{
// Arrange
Process? process = null;
const string TraceFileName = TraceFileClassName + "_ValidEmailPassword";
using IPlaywright playwright = await Playwright.CreateAsync();
IBrowser browser = await playwright.Chromium.LaunchAsync(new() { Headless = true });
IBrowser browser = await playwright.Chromium.LaunchAsync(new() { Headless = false });
IBrowserContext context = await browser.NewContextAsync(new BrowserNewContextOptions { IgnoreHTTPSErrors = true });
await context.Tracing.StartAsync(new() { Screenshots = true, Snapshots = true, Sources = true });

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public WebAppCallsApiCallsGraphLocally(ITestOutputHelper output)
_output = output;
}

[Fact]
[Fact(Skip = "https://github.com/AzureAD/microsoft-identity-web/issues/2716")]
[SupportedOSPlatform("windows")]
public async Task ChallengeUser_MicrosoftIdFlow_LocalApp_ValidEmailPasswordCreds_TodoAppFunctionsCorrectly()
{
Expand Down

0 comments on commit b705423

Please sign in to comment.