Fix thread safety issues in TokenAcquisition classes #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrik-me
reviewed
Mar 24, 2021
henrik-me
reviewed
Mar 24, 2021
henrik-me
reviewed
Mar 24, 2021
henrik-me
reviewed
Mar 24, 2021
bgavrilMS
reviewed
Mar 24, 2021
src/Microsoft.Identity.Web/AppServicesAuth/AppServicesAuthenticationTokenAcquisition.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Mar 24, 2021
src/Microsoft.Identity.Web/AppServicesAuth/AppServicesAuthenticationTokenAcquisition.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Mar 24, 2021
src/Microsoft.Identity.Web/AppServicesAuth/AppServicesAuthenticationTokenAcquisition.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Mar 24, 2021
src/Microsoft.Identity.Web/AppServicesAuth/AppServicesAuthenticationTokenAcquisition.cs
Outdated
Show resolved
Hide resolved
|
Would like to see us test this out. I would like though to split out the change done for creating new CC objects from the change on locking. |
jennyf19
reviewed
Mar 25, 2021
jennyf19
reviewed
Mar 25, 2021
|
going to merge to another branch and we will fix up anything as we test if needed. thank you so much @DavidParks8 |
Merged
jennyf19
added a commit
that referenced
this pull request
Mar 29, 2021
* Fix thread safety issues in TokenAcquisition classes (#1082) * Fix thread safety issues in TokenAcquisition classes * fix tests * Add confidential client app locking back * fix warnings * add more locks on httpContext * one more Co-authored-by: David Parks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some cases where highly multithreaded environments could cause issues due to non thread-safe code. This PR attempts to resolve the thread safety issues with an eye on maintaining performant execution.