Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking #1099

Merged
merged 8 commits into from
Mar 29, 2021
Merged

Locking #1099

merged 8 commits into from
Mar 29, 2021

Conversation

jennyf19
Copy link
Collaborator

From @DavidParks8 original PR, as we need to test, so merged to this branch instead of master.

FYI @jmprieur

i will either make these changes here or soon after merging.

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2021

Copy link
Collaborator

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @jennyf19

I love the simplification of the code in some parts

@jennyf19 jennyf19 merged commit 8137188 into master Mar 29, 2021
@jennyf19 jennyf19 deleted the locking branch May 31, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants