Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Collection: fix wrong UTF8 encoding, 3ds Max binary copied to output folder and other issues #1126

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Bugfix Collection: fix wrong UTF8 encoding, 3ds Max binary copied to output folder and other issues #1126

merged 9 commits into from
Oct 31, 2024

Conversation

FrogsInSpace
Copy link
Contributor

Fixes following recently introduced issues:

Also includes fixes for the following, longstanding issues:

@FrogsInSpace FrogsInSpace changed the title Bugfix Collection: for Bugfix Collection: fix wrong UTF8 encoding, 3ds Max binary copied to output folder and other issues Oct 31, 2024
@FrogsInSpace FrogsInSpace mentioned this pull request Oct 31, 2024
Closed
@FrogsInSpace
Copy link
Contributor Author

This should make the 3ds Max 2025 release usable at last

SergioRZMasson
SergioRZMasson requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@SergioRZMasson SergioRZMasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little tab vs spaces issue.

3ds Max/Max2Babylon/Exporter/BabylonExporter.Texture.cs Outdated Show resolved Hide resolved
SergioRZMasson
SergioRZMasson approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@SergioRZMasson SergioRZMasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SergioRZMasson SergioRZMasson merged commit a1a1d82 into BabylonJS:master Oct 31, 2024
5 checks passed
@FrogsInSpace
Copy link
Contributor Author

Just did a quick test of the installer and 3ds Max 2025 and everything seems to work as expected
Thanks a lot !

@SergioRZMasson
Copy link
Contributor

Nice! Thank you very much for you contribution @FrogsInSpace !

@AlexZhigin
Copy link

AlexZhigin commented Nov 1, 2024 •
edited
Loading

Just did a quick test of the installer and 3ds Max 2025 and everything seems to work as expected Thanks a lot !

Checked in 23 max - everything works as it should. Thanks!

@FrogsInSpace FrogsInSpace deleted the fix/small-bugfixes branch November 2, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRZMasson SergioRZMasson SergioRZMasson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrogsInSpace @SergioRZMasson @AlexZhigin