Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect context in policy report for app-level encryption #227

Merged
merged 3 commits into from
Dec 12, 2022
Merged

fix: Incorrect context in policy report for app-level encryption #227

merged 3 commits into from
Dec 12, 2022

Conversation

spdawson
Copy link
Contributor

Description

The policy for "application-level encryption missing" incorrectly reports context from schema.rb instead of structure.sql.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

spdawson and others added 3 commits December 12, 2022 07:49
@spdawson @cfabianski
fix: Incorrect context in policy report for app-level encryption
b98df3f 
The policy for "application-level encryption missing" incorrectly
reports context from `schema.rb` instead of `structure.sql`.

Co-authored-by: Cédric Fabianski <[email protected]>
@spdawson
chore: Update detectors to use new SchemaGroupShouldClose API
ec588ef
@spdawson
chore: Update snapshots
ff07f6b
@swarmia
Copy link

swarmia bot commented Dec 12, 2022

✅  Linked to AMA-3333 · Fix incorrect context in policy report for app-level encryption: reports context from schema.rb instead of structure.sql
➡️  Part of AMA-2947 · OSS - Curio CLI

@spdawson spdawson merged commit 727bf8b into main Dec 12, 2022
@spdawson spdawson deleted the AMA-3333-fix-incorrect-context-in-policy-report-for-app-level-encryption-reports-context-from-schema-rb-instead-of-structure-sql branch December 12, 2022 09:07
spdawson added a commit that referenced this pull request Dec 12, 2022
@spdawson
fix: remove defunct create_table detector
be30088 
Follow-up for #227
@spdawson spdawson mentioned this pull request Dec 12, 2022
Merged
4 tasks
spdawson added a commit that referenced this pull request Dec 12, 2022
@spdawson
fix: remove defunct create_table detector
f252ae6 
Follow-up for #227
spdawson added a commit that referenced this pull request Dec 12, 2022
@spdawson
fix: remove defunct create_table detector (#228)
b87a3d9 
Follow-up for #227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spdawson @cfabianski