Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove defunct create_table detector #228

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix: remove defunct create_table detector #228

merged 1 commit into from
Dec 12, 2022

Conversation

spdawson
Copy link
Contributor

Description

Follow-up for #227; the "create table" detector is no longer needed, now that we are using the custom detector to handle CREATE TABLE SQL statements.

Checklist

  • I've added test coverage that shows my fix or feature works as expected.
  • I've updated or added documentation if required.
  • I've included usage information in the description if CLI behavior was updated or added.
  • PR title follows Conventional Commits format

@spdawson spdawson force-pushed the fix/remove-defunct-create_table-detection branch from be30088 to f252ae6 Compare December 12, 2022 10:22
@spdawson spdawson merged commit b87a3d9 into main Dec 12, 2022
@spdawson spdawson deleted the fix/remove-defunct-create_table-detection branch December 12, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfabianski cfabianski cfabianski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spdawson @cfabianski