-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash should be the *ip preamble #9
Comments
Why not everything except the preamble, as discussed in #5? |
Typically in the documents this metadata is specially formatted, either as a code-fenced block or (maybe somewhere I've seen...) I guess we'll also need a spec for how this is formatted exactly? At for least for where the "preamble" starts and stops. Because I don't want to accidentally include an extra tab, newline, |
So for example the preamble could be
yea? |
[brought this from #10] Hi @whilei the idea of the startIP system is to create a deterministic numbering so that all ECIPs can be decentralized in different repos, but with a common standard. These are examples of centralized preambles in BIP, EIP, ECIP: BIP:
EIP:
ECIP:
|
closed this issue by mistake...sorry! re-opened! |
agree with @whilei , consistent format is crucial for hashes |
What if we use a specific JSON format and we have a script here that automatically lints it and checks if the order is in a correct format. We can then include the lint and validator script for the preamble as part of the starIP package that people would need to fork. Lint takes care of whitespace issues and ensures correct formatting and tab space. We can even simplify it as a YAML file: title: <starIP Title>
author: <starIP Author>
discussions-to: <a url pointing to the official discussion thread>
status: <Draft | Last Call | Accepted | Final | Active | Deferred | Rejected | Superseded>
type: <Standards Track (Core, Networking, Interface, ERC) | Informational | Meta>
created: <date created on, in ISO 8601 (yyyy-mm-dd) format>
replaces: <starIP number(s)>
superseded-by: <starIP number(s)>
resolution: <a url pointing to the resolution of this EIP> |
what if instead of |
If this is a good solution, I propose from {teamName}-{root}-{number} to {root}-{teamName}-{number} like
|
@meowsbits 1. I do like the idea of the 'front matter' as the name. It was suggested to call it the preamble. As for formatting, I suggest we add to this repo some restriction or preprocessing of the preamble that is required. In this specific case, we can say that @YazzyYaz linting tool sounds good to me. Can you make a ticket and describe the work in there? Having a @meowsbits that would certainly work, though I think this is a layer above what we are proposing / the scope of this repo. We are only suggesting a deterministic versioning scheme and numbering scheme, as well as a name that should be generic enough for any project. That being said, I think there is lots of opportunity to wrap the name in any kind of other spec, as @sorpaas has done in his ecip 24. I'm thinking simplest and smallest change is best. This allows for the many things to be tried, experimented with, and added only if absolutely necessary. |
@BelfordZ Will make a ticket for sure! |
@YazzyYaz there were some good points made against having a machine format on a different issue #5 . I also think it's good not to drop a bomb on people by changing too many things at once, especially not making them write in some formatted syntax (although I'd totally support the json format if there was a subproject in *IP repository that was a website with input fields for each preamble entry and a live markdown preview with a button to generate the *IP json). But this brings additional work. That said, I totally support the linter for the plain text format and we can then transform it to our own formats if we want to (yaml, json,..) and share them via ecipuri network or similar. |
except we must remove ECIP number cause that part woul;dnt make sense
The text was updated successfully, but these errors were encountered: