fix: zoom does not work when pinching on mobile #499
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurkowski
approved these changes
Oct 4, 2024
alexbft
added a commit
to alexbft/cbzweb
that referenced
this pull request
Oct 12, 2024
2 tasks
github-merge-queue bot
pushed a commit
to powerhome/playbook
that referenced
this pull request
Oct 22, 2024
**What does this PR do?** Upgrade react-zoom-pan-pinch from 2.6.1 to 3.6.0 Fix "pinch" bug on mobile and tablet by avoiding [3.6.1 version](https://github.com/BetterTyped/react-zoom-pan-pinch/releases/tag/v3.6.1) which has a bug with "double click" and "two fingers" on zoom. See discussion in [GitHub issues](BetterTyped/react-zoom-pan-pinch#487). Someone made a [PR](BetterTyped/react-zoom-pan-pinch#499) which hasn't been merged yet, so this might be fixed in later versions. **How to test?** Go through the Lightbox kit for any regressions #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #487
I have output the log of touch events during a pinch on mobile, and it seems to be behaving as follows:
event.touches.length === 2is fired only once at the pinch startevent.touches.length === 1andevent.touches.length === 2In case 1, the pinch works correctly. However, in case 2, the quick, consecutive tap events are interpreted as a double-tap.
To address case 2, I have changed it so that only single-finger touches are treated as a double-tap.