[PLAY-1601] Bump react-zoom-pan-pinch from 2.6.1 to 3.6.0 #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangaree
added
improvement
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.5.0.pre.alpha.PLAY1601updatereactzoompanpinch4123 Your Alpha for NPM is 14.5.0-alpha.PLAY1601updatereactzoompanpinch4123 |
BetterTyped/react-zoom-pan-pinch#487 Double click causes issues on mobile for two fingers
kangaree
changed the title
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.5.0.pre.alpha.PLAY1601updatereactzoompanpinch4128 Your Alpha for NPM is 14.5.0-alpha.PLAY1601updatereactzoompanpinch4128 |
kangaree
added
the
milano
nidaqg
approved these changes
Oct 22, 2024
nidaqg
added
Product Approved
|
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade react-zoom-pan-pinch from 2.6.1 to 3.6.0
Fix "pinch" bug on mobile and tablet by avoiding 3.6.1 version which has a bug with "double click" and "two fingers" on zoom.
See discussion in GitHub issues.
Someone made a PR which hasn't been merged yet, so this might be fixed in later versions.
How to test?
Go through the Lightbox kit for any regressions
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.