Feature/transaction state #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| debited_account=self.accA, | ||
| credited_account=self.accB, | ||
| event=self.event | ||
| ).save() |
There was a problem hiding this comment.
Le .save() est inutile (il est présent dans le test au-dessus juste pour vérifier que la transaction n'est pas comptée deux fois quand elle est créée deux fois ;) )
| try : | ||
| transaction = Transaction.objects.get(id=pk) | ||
| except Transaction.DoesNotExist: | ||
| return HttpResponse(status=404) |
There was a problem hiding this comment.
Même remarque ici : HttpResponse est avantageusement remplacé par Response :)
Et, pour en-dessous, les Response({'status': 'State modified'}) peuvent être remplacées par juste des Response ; vu que le message "tout s'est bien passé" est déjà transmis par le code HTTP 200 :)
|
@Ekleog Cette PR a-t-elle encore un intérêt ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifier l'état des permissions sans gestion des permissions.
Codage de la fonction "setState", avec en prévision des permissions, deux types de changements.
Codage d'un test fonctionnel