-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/transaction state #29
Open
kalaspa
wants to merge
7
commits into
develop
Choose a base branch
from
feature/transactionState
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f67d334
mise en place de fonctions de changements d'etat
56ec404
Utilisation fonctionnelle
51fb453
Utilisation fonctionnelle
2af4393
Correct response when errors occure
919a5c0
Adds a test
d1ad455
Better response
e78dbba
Suppression de .save() inutiles
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,3 +20,4 @@ | |
coverage | ||
node_modules | ||
npm-debug.log | ||
env/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,39 @@ | ||
from rest_framework.response import Response | ||
from rest_framework import viewsets | ||
from rest_framework import exceptions | ||
from rest_framework.decorators import detail_route | ||
from django.http import HttpResponse | ||
|
||
from platalbank_core.models import Transaction | ||
from platalbank_core.serializers import TransactionSerializer | ||
|
||
class TransactionViewSet(viewsets.ModelViewSet): | ||
queryset = Transaction.objects.all() | ||
serializer_class = TransactionSerializer | ||
|
||
@detail_route(methods=['post']) | ||
def setState(self, request, pk=None): | ||
|
||
try : | ||
transaction = Transaction.objects.get(id=pk) | ||
except Transaction.DoesNotExist: | ||
return HttpResponse(status=404) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Même remarque ici : HttpResponse est avantageusement remplacé par Response :) Et, pour en-dessous, les Response({'status': 'State modified'}) peuvent être remplacées par juste des Response ; vu que le message "tout s'est bien passé" est déjà transmis par le code HTTP 200 :) |
||
|
||
state = request.data.get('state') | ||
|
||
#Une fois les permissions implementees, ce type de changement d'etat demandera des permissions Khube ou User | ||
if (state in [Transaction.AUTHORIZED , Transaction.REJECTED]): | ||
transaction.state = state | ||
transaction.save() | ||
|
||
return Response({'status':'State modified'}) | ||
|
||
#Ce type de changement d'etat demandera des permissions seller | ||
elif (state in [Transaction.ABORTED,Transaction.COMPLETED]): | ||
transaction.state = state | ||
transaction.save() | ||
|
||
return Response({'status':'State modified'}) | ||
|
||
else : | ||
raise exceptions.PermissionDenied |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le .save() est inutile (il est présent dans le test au-dessus juste pour vérifier que la transaction n'est pas comptée deux fois quand elle est créée deux fois ;) )